Recognize headless errors on requirement operations #2876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MDrakos
commented
Nov 9, 2023
•
MDrakos
commented
 DX-2224 Remove headless commits
|
|
Test failures are not due to the changes introduced in this PR |
mitchell-as
requested changes
Nov 10, 2023
| @@ -17,6 +17,8 @@ var ErrNotAuthenticated = errors.New("not authenticated") | |||
|
|
|||
| var ErrActionAborted = errors.New("aborted by user") | |||
|
|
|||
| var ErrHeadless = errors.New("headless") | |||
There was a problem hiding this comment.
I view errors in this file as "global" errors. Is this going to be used outside the internal/runbits/requirements package? If not, we should put it in that package and remove it here.
There was a problem hiding this comment.
Never mind, I think this will be used in user-facing errors for requirement operations like install/uninstall.
mitchell-as
approved these changes
Nov 10, 2023
| @@ -17,6 +17,8 @@ var ErrNotAuthenticated = errors.New("not authenticated") | |||
|
|
|||
| var ErrActionAborted = errors.New("aborted by user") | |||
|
|
|||
| var ErrHeadless = errors.New("headless") | |||
There was a problem hiding this comment.
Never mind, I think this will be used in user-facing errors for requirement operations like install/uninstall.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.